-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-138004: Encode thread names on Solaris-based platforms as ASCII and fix main/worker threading test #138017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
d97417d
fix threadmodule ascii and make test more lenient
jadonduff 1db08a7
📜🤖 Added by blurb_it.
blurb-it[bot] 0606968
implement requested changes
jadonduff b556774
reformat and remove test news
jadonduff 38a75d3
patch for windows & non-posix compliant platforms
jadonduff 31731b1
patch
jadonduff 83fe205
Check if generated files are up to date patch
jadonduff aadf7f3
test
jadonduff 612a0a4
test2
jadonduff 1fa51f8
test3
jadonduff d24d0bb
attempt fix
jadonduff 95d289f
Merge branch 'main' into thread_name_fix
jadonduff d7a47bf
test
jadonduff 1970a00
fix stray newline
jadonduff 6395323
Merge branch 'main' into thread_name_fix
jadonduff 241e097
Apply suggestions from code review
jadonduff 66c058b
fixes
jadonduff f817412
apply fixes (built)
jadonduff 3349464
remove dead code, fix err var, revert newline, fix comment
jadonduff ac3d3dd
redundant err var replaced
jadonduff 1ab9ecd
replaced functions with inline code, moved into set_thread_name_with_…
jadonduff d9ba9e8
revert
jadonduff d7025f5
inline test
jadonduff 3689044
test fix for "Check if generated files are up to date"
jadonduff 246f880
fix linker error
jadonduff 407b1e9
make regen
jadonduff dc43fc4
move functions and add inline for functions used once
jadonduff 7aa256c
remove duplicated __sun enforcing utf-8 from encoder
jadonduff b4934a2
consolidate functions, remove unrelated changes
jadonduff ae5ac4b
clinic regen fix
jadonduff 4fc368d
fix error/fallback (implement changes)
jadonduff 392aa5a
fix whitespace lint issue in test_threading.py
jadonduff 84daea4
Merge branch 'main' into thread_name_fix
jadonduff d5e9399
make _threadmodule.c clearer, remove unrelated change, add specific t…
jadonduff 105d4e6
Merge branch 'main' into thread_name_fix
jadonduff c67e93d
Merge branch 'main' into thread_name_fix
jadonduff 508f24d
add test for main and encode ascii
jadonduff 25085bf
encode ascii on solaris/openindiana
jadonduff cd26833
Merge branch 'main' into thread_name_fix
jadonduff dc86a29
test_threading main name fixed, minor changes, news
jadonduff c9f554d
Merge branch 'main' into thread_name_fix
jadonduff c0f672e
Lint fix
jadonduff 69796ff
Update replace to surrogateescape
jadonduff 15c8481
fix comment length
jadonduff 99f13ec
Merge branch 'main' into thread_name_fix
jadonduff 8fc613b
fix comments and move thread name reset in test
jadonduff 5e5effb
revert name reset to original position
jadonduff 9690eee
Merge branch 'main' into thread_name_fix
jadonduff 338593c
Update Modules/_threadmodule.c
serhiy-storchaka e642264
Fix EOL.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2025-08-21-06-31-42.gh-issue-138004.FH2Hre.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| On Solaris/Illumos platforms, thread names are now encoded as ASCII to avoid errors on systems (e.g. OpenIndiana) that don't support non-ASCII names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.