Skip to content

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Aug 22, 2025

@AA-Turner
Copy link
Member

cc @encukou, we've just reworded this section.

Perhaps this PR should be deferred in favour of the eventual goal of automatically generating the grammar snippets in the documentation for the actual grammar?

A

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Aug 22, 2025

After all of the work put in to improve the snippets, I think it would be worse as the actual grammar would be much less reader friendly.

Furthermore, for this specific case the parsing is done by string_parser.c (IIRC the name) and is not explicitly defined in the grammar.

@encukou
Copy link
Member

encukou commented Sep 2, 2025

Pablo's comment from the issue -- “The change is not incorrect and is technically a bit more precise on the order” -- applies to this one as well.
It's a small improvement, but let's still merge it.

@encukou encukou merged commit 0a0cbd4 into python:main Sep 2, 2025
34 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Sep 2, 2025
@StanFromIreland
Copy link
Member Author

Per comment on issue.

@StanFromIreland StanFromIreland added the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@StanFromIreland StanFromIreland deleted the lex-ana-order branch September 2, 2025 12:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 2, 2025

GH-138373 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
hugovk pushed a commit that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants