-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-110936: Improve string literal definition in Lexical Analysis #138063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @encukou, we've just reworded this section. Perhaps this PR should be deferred in favour of the eventual goal of automatically generating the grammar snippets in the documentation for the actual grammar? A |
After all of the work put in to improve the snippets, I think it would be worse as the actual grammar would be much less reader friendly. Furthermore, for this specific case the parsing is done by |
Pablo's comment from the issue -- “The change is not incorrect and is technically a bit more precise on the order” -- applies to this one as well. |
Per comment on issue. |
Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
pythonGH-138063) (cherry picked from commit 0a0cbd4) Co-authored-by: Stan Ulbrych <[email protected]>
GH-138373 is a backport of this pull request to the 3.14 branch. |
…is (GH-138063) (#138373) Co-authored-by: Stan Ulbrych <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--138063.org.readthedocs.build/