gh-137589: Zipfile tests: close file objects #138080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I'll try to get to reviewing this tomorrow, been a hectic week. |
emmatyping
approved these changes
Sep 1, 2025
emmatyping
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2025
Zipfile tests: close file objects (cherry picked from commit 5cea843) Co-authored-by: Rogdham <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 8, 2025
Zipfile tests: close file objects (cherry picked from commit 5cea843) Co-authored-by: Rogdham <[email protected]>
|
GH-139766 is a backport of this pull request to the 3.14 branch. |
|
GH-139767 is a backport of this pull request to the 3.13 branch. |
vstinner
pushed a commit
that referenced
this pull request
Oct 8, 2025
vstinner
pushed a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
ZipFileinstances were not closed in tests.I tried to stick to the style of the tests around, to decide between using a context manager and calling
.close()manually. Tell me if you want some to be changed.See the issue for more information. I am unsure if this should be backported to 3.14 or even earlier, given the fact that it's only tests and impact has been seen only when running with PyPy.