Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/test_sys_settrace.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ class TraceTestCase(unittest.TestCase):
# Disable gc collection when tracing, otherwise the
# deallocators may be traced as well.
def setUp(self):
if os.environ.get('PYTHON_UOPS_OPTIMIZE') == '0':
self.skipTest("Line tracing behavior differs when JIT optimizer is disabled")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why/how does the behavior differ? Sounds like a bug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should open another issue for this.

self.using_gc = gc.isenabled()
gc.disable()
self.addCleanup(sys.settrace, sys.gettrace())
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_trace.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ def test_traced_func_linear(self):

self.assertEqual(self.tracer.results().counts, expected)

@unittest.skipIf(os.environ.get('PYTHON_UOPS_OPTIMIZE') == '0',
"Line counts differ when JIT optimizer is disabled")
def test_traced_func_loop(self):
self.tracer.runfunc(traced_func_loop, 2, 3)

Expand All @@ -166,6 +168,8 @@ def test_traced_func_importing(self):

self.assertEqual(self.tracer.results().counts, expected)

@unittest.skipIf(os.environ.get('PYTHON_UOPS_OPTIMIZE') == '0',
"Line counts differ when JIT optimizer is disabled")
def test_trace_func_generator(self):
self.tracer.runfunc(traced_func_calling_generator)

Expand Down Expand Up @@ -236,6 +240,8 @@ def setUp(self):
self.my_py_filename = fix_ext_py(__file__)
self.addCleanup(sys.settrace, sys.gettrace())

@unittest.skipIf(os.environ.get('PYTHON_UOPS_OPTIMIZE') == '0',
"Line counts differ when JIT optimizer is disabled")
def test_exec_counts(self):
self.tracer = Trace(count=1, trace=0, countfuncs=0, countcallers=0)
code = r'''traced_func_loop(2, 5)'''
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix JIT trace buffer overrun by increasing possible exit stubs.
Patch by Donghee Na.
9 changes: 2 additions & 7 deletions Python/optimizer.c
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,8 @@ translate_bytecode_to_trace(

for (;;) {
target = INSTR_IP(instr, code);
// Need space for _DEOPT
max_length--;
// Every instruction might need _DEOPT, and _DEOPT might have _ERROR_POP_N before it
max_length -= 2;

uint32_t opcode = instr->op.code;
uint32_t oparg = instr->op.arg;
Expand Down Expand Up @@ -652,11 +652,6 @@ translate_bytecode_to_trace(
RESERVE_RAW(2, "_EXIT_TRACE");
max_length--;
}
if (OPCODE_HAS_ERROR(opcode)) {
// Make space for error stub and final _EXIT_TRACE:
RESERVE_RAW(2, "_ERROR_POP_N");
max_length--;
}
switch (opcode) {
case POP_JUMP_IF_NONE:
case POP_JUMP_IF_NOT_NONE:
Expand Down
Loading