Skip to content

Conversation

00ll00
Copy link
Contributor

@00ll00 00ll00 commented Aug 29, 2025

  • Add a check for the type statement in function is_soft_keyword_used.

@python-cla-bot
Copy link

python-cla-bot bot commented Aug 29, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Aug 29, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

00ll00 and others added 2 commits August 29, 2025 21:25
@picnixz
Copy link
Member

picnixz commented Aug 29, 2025

my bad, my suggestion had an extra : (you can just fix it in a separate commit)

@00ll00
Copy link
Contributor Author

00ll00 commented Aug 29, 2025

my bad, my suggestion had an extra : (you can just fix it in a separate commit)

I didn’t notice the issue here, let me fix it. 😊

@00ll00
Copy link
Contributor Author

00ll00 commented Sep 1, 2025

The commit above also fixed the missing handling for type statement after DEDENT, discovered while adding test cases. 😌

@00ll00 00ll00 requested a review from pablogsal September 5, 2025 14:19
@ambv ambv merged commit 26cfb17 into python:main Sep 15, 2025
53 checks passed
@ambv ambv added the needs backport to 3.14 bugs and security fixes label Sep 15, 2025
@miss-islington-app
Copy link

Thanks @00ll00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 15, 2025
…nts in the REPL (pythonGH-138241)

(cherry picked from commit 26cfb17)

Co-authored-by: 00ll00 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 15, 2025

GH-138937 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 15, 2025
@00ll00 00ll00 deleted the repl-highlight branch September 16, 2025 04:08
encukou pushed a commit that referenced this pull request Oct 7, 2025
…ents in the REPL (GH-138241) (GH-138937)

(cherry picked from commit 26cfb17)

Co-authored-by: 00ll00 <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants