Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Aug 31, 2025

Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Co-authored-by: Tomas R. <[email protected]>
@AlexWaygood AlexWaygood removed their request for review August 31, 2025 15:32
@AA-Turner AA-Turner enabled auto-merge (squash) August 31, 2025 20:06
@AA-Turner AA-Turner merged commit 78acd8e into python:main Aug 31, 2025
43 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Raspbian 3.x (tier-3) has failed when building commit 78acd8e.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1678/builds/751) and take a look at the build logs.
  4. Check if the failure is related to this commit (78acd8e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1678/builds/751

Failed tests:

  • test.test_multiprocessing_fork.test_processes

Failed subtests:

  • test_interrupt - test.test_multiprocessing_fork.test_processes.WithProcessesTestProcess.test_interrupt

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-149' pid=615091 parent=614557 started daemon>


Traceback (most recent call last):
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 596, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 577, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/stan/buildarea/3.x.stan-raspbian.nondebug/build/Lib/test/_test_multiprocessing.py", line 573, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-1' pid=632464 parent=632462 started daemon>

@StanFromIreland
Copy link
Member Author

Unrelated, has been flakey for a while.

Backports seem like a good idea, otherwise we’ll have problems with conflicts later.

@StanFromIreland StanFromIreland deleted the lint-i18n branch August 31, 2025 21:17
@sobolevn
Copy link
Member

sobolevn commented Sep 4, 2025

We generally backport PRs like this, because otherwise it would be hard to backport actual fixes :)

@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 4, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @StanFromIreland and @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 78acd8e95e78bc410b8207cd60e1323ece01b3d5 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2025
(cherry picked from commit 78acd8e)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 4, 2025

GH-138513 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 4, 2025
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Sep 4, 2025

I will do the 3.13 backport (tomorrow).

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Sep 5, 2025
(cherry picked from commit 78acd8e)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138524 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 5, 2025
hugovk pushed a commit that referenced this pull request Sep 5, 2025
* [3.13] gh-138286: Run ``ruff`` on ``Tools/i18n`` (GH-138287)
(cherry picked from commit 78acd8e)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>

* Commit

* Commit

---------

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
hugovk pushed a commit that referenced this pull request Sep 5, 2025
Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…) (python#138513)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Tomas R. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants