-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-138286: Run ruff on Tools/i18n
#138287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Co-authored-by: Tomas R. <[email protected]>
|
|
Unrelated, has been flakey for a while. Backports seem like a good idea, otherwise we’ll have problems with conflicts later. |
|
We generally backport PRs like this, because otherwise it would be hard to backport actual fixes :) |
|
Thanks @StanFromIreland for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @StanFromIreland for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @StanFromIreland and @AA-Turner, I could not cleanly backport this to |
(cherry picked from commit 78acd8e) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]>
|
GH-138513 is a backport of this pull request to the 3.14 branch. |
|
I will do the 3.13 backport (tomorrow). |
(cherry picked from commit 78acd8e) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]>
|
GH-138524 is a backport of this pull request to the 3.13 branch. |
* [3.13] gh-138286: Run ``ruff`` on ``Tools/i18n`` (GH-138287) (cherry picked from commit 78acd8e) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]> * Commit * Commit --------- Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]>
…) (python#138513) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]>
Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Tomas R. <[email protected]>
ruffonTools/i18n#138286