gh-138349: Fix crash when combining module-level annotation and listcomp

[JelleZijlstra]

The bug was that we used the wrong name list to get __conditional_annotations__, which caused us to emit a SET_ADD that was adding to something that wasn't a set. This manifested as a hang on debug builds and a crash on release builds for whatever reason, but the issue became more apparent when I added an assertion to setobject.c to make sure we were only adding to sets.

• Issue: SIGSEGV in Python 3.14.0rc2+ with List Comprehension and Lambda Expression #138349

[Fidget-Spinner]

Do you need to bump the pyc magic number as well? I forgot whether bytecode invalidation matters here.

[markshannon]

The changes look correct to me, but I've not looked that closely at the conditional annotation code.
This will need a magic number bump as the old pycs could cause crashes.

[vstinner]

This will need a magic number bump as the old pycs could cause crashes.

@JelleZijlstra: Can you update the magic number (in Include/internal/pycore_magic_number.h) please?

[JelleZijlstra]

Done

[vstinner]

LGTM. The changes does fix the crash and the added tests check for non-regression.

[miss-islington-app]

Thanks @JelleZijlstra for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @JelleZijlstra and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a6fd4a45deee23b827bf8e32bde172e14921ed6 3.14

[bedevere-app]

GH-138749 is a backport of this pull request to the 3.14 branch.

[vstinner]

Merged, thanks @JelleZijlstra. I wrote a backport to 3.14 (I adapted the magic number for 3.14).