Skip to content

GH-138378: Move globals-to-consts pass into main optimizer pass #138379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 18, 2025
Merged

GH-138378: Move globals-to-consts pass into main optimizer pass #138379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
edfe8a3
Move globals-to-consts pass into main optimizer pass
markshannon Sep 1, 2025
afb911b
Add news
markshannon Sep 3, 2025
91e6eae
Address review comments
markshannon Sep 3, 2025
525a2de
Move builtins-watched to correct scope
markshannon Sep 3, 2025
42e32d1
Add test for #136154
markshannon Sep 3, 2025
ab5374d
Merge branch 'main' into move-globals-removal-to-main-optimizer-pass
markshannon Sep 3, 2025
863d947
Merge branch 'main' into move-globals-removal-to-main-optimizer-pass
markshannon Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Include/internal/pycore_optimizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,10 @@ struct _Py_UOpsAbstractFrame {
// Max stacklen
int stack_len;
int locals_len;
uint32_t globals_checked_version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, this should be placed after the last few fields in the current struct and they should be commented. E.g. // globals to constant promotion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields should be in either ascending or descending order, for best packing, so I can't just add the fields at the end.
I'll add the comment.

bool builtins_watched;
bool globals_watched;
PyFunctionObject *func;

JitOptRef *stack_pointer;
JitOptRef *stack;
Expand Down
Loading
Loading