[3.13] gh-137920: Fix semantically relevant typo in curses.window.attron (GH-137940)
#138507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
@vict-Yang Please see #138506 (comment) |
|
Considering there hasn't been a reply since then, I would suggest you to simply remove the author from the commit, but acknowledge them normally in the commit message. |
picnixz
approved these changes
Sep 29, 2025
|
I thought about replacing the email with the one they used for commits in the PR, but I worry they may not use it for some specific reason, so I'll just remove. |
…dow.attron` (pythonGH-137940) Originally authored by: vict-Yang (cherry picked from commit ce70a57)
StanFromIreland
force-pushed
the
backport-ce70a57-3.13
branch
from
19f0019 to
fb10895
Compare
|
Added:
To avoid the email issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ce70a57)
curses.window.attron#137920📚 Documentation preview 📚: https://cpython-previews--138507.org.readthedocs.build/