Skip to content

Conversation

ian293382
Copy link

@ian293382 ian293382 commented Sep 5, 2025

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 5, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 5, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Sep 5, 2025
@ian293382 ian293382 changed the title gh-137970:add st_mode_notice code_example gh-137970: add st_mode_notice code_example Sep 5, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pre-commit to fix the failing lint job.


.. note::

``st_mode`` is an **int** bitmask that combines the file type and the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a Sphinx reference instead of making it bold:

Suggested change
``st_mode`` is an **int** bitmask that combines the file type and the
``st_mode`` is an :class:`int` bitmask that combines the file type and the

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've applied the change, thanks for the suggestion.

@ian293382 ian293382 force-pushed the gh-137970-ADD-st-mode-notice branch 2 times, most recently from 134e987 to 45523e0 Compare September 5, 2025 18:14
@ian293382 ian293382 force-pushed the gh-137970-ADD-st-mode-notice branch from 45523e0 to ee75661 Compare September 5, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants