Skip to content

gh-138584: Fix missing type2test in Lib/tests/list_tests.py #138590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2025
Merged

gh-138584: Fix missing type2test in Lib/tests/list_tests.py #138590

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1abb97
Use self.type2test in list_tests.CommonTest
Devansh-b Sep 6, 2025
fb654a3
gh-138584: Add NEWS entry for missing type2test in list_tests
Devansh-b Sep 6, 2025
d1c4a2a
Remove NEWS entry for missing type2test in list_tests
Devansh-b Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/test/list_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ def test_init(self):
self.assertEqual(a, b)

def test_getitem_error(self):
a = []
a = self.type2test([])
msg = "list indices must be integers or slices"
with self.assertRaisesRegex(TypeError, msg):
a['a']

def test_setitem_error(self):
a = []
a = self.type2test([])
msg = "list indices must be integers or slices"
with self.assertRaisesRegex(TypeError, msg):
a['a'] = "python"
Expand Down Expand Up @@ -561,7 +561,7 @@ def test_constructor_exception_handling(self):
class F(object):
def __iter__(self):
raise KeyboardInterrupt
self.assertRaises(KeyboardInterrupt, list, F())
self.assertRaises(KeyboardInterrupt, self.type2test, F())

def test_exhausted_iterator(self):
a = self.type2test([1, 2, 3])
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
gh-138584: Fixed list_tests.CommonTest to use type2test in test_getitem_error, test_setitem_error, and test_constructor_exception_handling in Lib/tests/list_tests.py.
Loading