Skip to content

gh-138614: site._get_path to respect non-default implementation name #138610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
+1 −1
Merged

gh-138614: site._get_path to respect non-default implementation name #138610

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2a2490
`site._get_path` to respect non-default implementation name
ShaharNaveh Sep 7, 2025
503c8fc
Add news entry
ShaharNaveh Sep 7, 2025
25c074a
Merge remote-tracking branch 'upstream/main' into fix-site-path-impl-…
ShaharNaveh Oct 4, 2025
27c78ce
Remove NEWS entry
ShaharNaveh Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/site.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ def _get_path(userbase):
if sys.platform == 'darwin' and sys._framework:
return f'{userbase}/lib/{implementation_lower}/site-packages'

return f'{userbase}/lib/python{version[0]}.{version[1]}{abi_thread}/site-packages'
return f'{userbase}/lib/{implementation_lower}{version[0]}.{version[1]}{abi_thread}/site-packages'


def getuserbase():
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-09-07-12-43-51.gh-issue-138614.7-4rrs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:mod:`site`: correctly synchronize the ``purelib`` installation scheme with
the one defined in :mod:`sysconfig`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some thoughts, what I wrote is a bit too obscure. Let's mention the public API:

Suggested change
:mod:`site`: correctly synchronize the ``purelib`` installation scheme with
the one defined in :mod:`sysconfig`.
:mod:`site`: correctly synchronize the ``purelib`` installation scheme with
the one defined in :mod:`sysconfig`. This affects the default user-specific
site-packages directory path (see :func:`site.getusersitepackages`).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the maintainer's feedback, you can remove the NEWS entry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any actual user-facing downstream issues? If so, we can keep the NEWS entry (with @picnixz's proposed change), otherwise I think we should just drop it.

cc @ShaharNaveh

Loading