Skip to content

gh-125522: remove bare except usage in Lib/_pyio.py #138625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-125522: remove bare except usage in Lib/_pyio.py #138625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a395121
refactor(Lib/_pyio): use explicit exception for `open` function
Lee-W Sep 7, 2025
a638f97
refactor(Lib/_pyio): use explicit exception for function
Lee-W Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/_pyio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def open(file, mode="r", buffering=-1, encoding=None, errors=None,
result = text
text.mode = mode
return result
except:
except (ValueError, OSError, TypeError, ImportError, LookupError):
result.close()
raise

Expand Down Expand Up @@ -1619,7 +1619,7 @@ def __init__(self, file, mode='r', closefd=True, opener=None):
except OSError as e:
if e.errno != errno.ESPIPE:
raise
except:
except (ValueError, TypeError, IsADirectoryError, OSError):
self._stat_atopen = None
if owned_fd is not None:
os.close(owned_fd)
Expand Down
Loading