[3.14] Use test.support.is_wasm32 flag for is_emscripten or is_wasi for generic checks (GH-136815)
#138643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r generic checks (pythonGH-136815) (cherry picked from commit aafb143) Co-authored-by: Ani <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
miss-islington
requested review from
FFY00,
barneygale,
brettcannon,
ericsnowcurrently,
ncoghlan,
vsajip and
warsaw
as code owners
bedevere-app
bot
added
awaiting review
skip issue
skip news
type-refactor
|
We tend to backport test changes because it makes other backports easier, eg in this case #138638. Not strictly required, though. A |
hugovk
approved these changes
Sep 8, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…asi` for generic checks (pythonGH-136815) (python#138643) Co-authored-by: Ani <[email protected]> Co-authored-by: Brett Cannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit aafb143)
Co-authored-by: Ani [email protected]
Co-authored-by: Brett Cannon [email protected]