gh-135335: Simplify preload regression test using __main__ #138686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the fix for pythongh-126631 __main__ modules can be preloaded and the regression test for pythongh-135335 can be simplified to just use a self-contained script rather than requiring a module. Note this assumes and implicitly tests that __main__ is preloaded by default.
|
I don't believe this needs a news entry, as it is just a refactoring/simplification of an existing regression test. |
StanFromIreland
added
skip news
type-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fix for gh-126631
__main__modules can be preloaded and the regression test for gh-135335 can be simplified to just use a self-contained script rather than requiring a module.Note this assumes and implicitly tests that
__main__is preloaded by default.