[3.14] gh-136006: fix Py_NAN expansion on Solaris systems (GH-136575)
#138733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…136575) On Solaris, `Py_NAN` may expand as a function address instead of a floating-point number. This amends commit 7a3b035. (cherry picked from commit d54b109) Co-authored-by: Bénédikt Tran <[email protected]>
This was referenced Sep 10, 2025
Member
|
FWIW, I generally don't backport fixes for unsupported platforms – our testing isn't useful there, and anyone porting Python should have a mechanism to manage patches. |
Member
Member
|
I would suggest to revert the 3.13 backport and close this PR. |
Member
|
(I'm at the PyCon UK sprint, we can do the revert PR.) |
Member
|
Ok. Let's revert 3.13. Could you take care of this Hugo? TiA. I'm currently working on something else. |
Member
|
Yep 👍 |
epbennetts
added a commit
to epbennetts/cpython
that referenced
this pull request
Sep 22, 2025
…tems (pythonGH-136575) (python#138734)" This reverts commit df34903 as discussed in python#138733 (comment)
hugovk
pushed a commit
that referenced
this pull request
Sep 22, 2025
…H-136575) (#138734)" (#139239) This reverts commit df34903 as discussed in #138733 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Solaris,
Py_NANmay expand as a function address instead of a floating-point number.This amends commit 7a3b035.
(cherry picked from commit d54b109)
Co-authored-by: Bénédikt Tran [email protected]