-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-71810: fix corner case (length==0) for int.to_bytes() #138739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
33f60b9
ea3d52f
f0090e7
db7182a
aff76b8
60732b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Raise :exc:`OverflowError` for ``(-1).to_bytes()`` for signed conversions | ||
when bytes count is zero. Patch by Sergey B Kirpichev. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1209,7 +1209,7 @@ _PyLong_AsByteArray(PyLongObject* v, | |
*p = (unsigned char)(accum & 0xff); | ||
p += pincr; | ||
} | ||
else if (j == n && n > 0 && is_signed) { | ||
else if (j == n && is_signed) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduced an undefined behavior: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, sorry. Thanks! |
||
/* The main loop filled the byte array exactly, so the code | ||
just above didn't get to ensure there's a sign bit, and the | ||
loop below wouldn't add one either. Make sure a sign bit | ||
|
Uh oh!
There was an error while loading. Please reload this page.