Skip to content

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 10, 2025

GitHub Actions is in the process of migrating windows-latest from windows-2022 to windows-2025:

This change will be rolled out over a period of several weeks beginning 2025-09-02 and will complete on 2025-09-30

actions/runner-images#12677

This is causing failures for forks which have already been migrated, for example:

======================================================================
FAIL: test_function_entry_return (test.test_dtrace.DTraceNormalTests.test_function_entry_return)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in normalize_trace_output
    result.sort(key=lambda row: int(row[0]))
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 38, in <lambda>
    result.sort(key=lambda row: int(row[0]))
                                ~~~^^^^^^^^
ValueError: invalid literal for int() with base 10: 'dtrace: failed to compile script D:\\a\\cpython\\cpython\\Lib\\test\\dtracedata\\call_stack.d: line 3: pid provider is not installed on this system'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 124, in test_function_entry_return
    self.run_case("call_stack")
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 119, in run_case
    actual_output, expected_output = self.backend.run_case(
                                     ~~~~~~~~~~~~~~~~~~~~~^
        name, optimize_python=self.optimize_python)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 53, in run_case
    actual_output = normalize_trace_output(self.trace_python(
        script_file=abspath(name + self.EXTENSION),
        python_file=abspath(name + ".py"),
        optimize_python=optimize_python))
  File "D:\a\cpython\cpython\Lib\test\test_dtrace.py", line 42, in normalize_trace_output
    raise AssertionError(
        "tracer produced unparsable output:\n{}".format(output)
    )
AssertionError: tracer produced unparsable output:
dtrace: failed to compile script D:\a\cpython\cpython\Lib\test\dtracedata\call_stack.d: line 3: pid provider is not installed on this system

https://github.com/picnixz/cpython/actions/runs/17610564159/job/50031376950#step:1:9

Upstream and my fork are still on 2022, but let's pin to windows-2022 so we can separately investigate and fix for 2025, and then pin to windows-2025.

@hugovk hugovk added OS-windows infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Sep 10, 2025
@hugovk hugovk added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip issue skip news labels Sep 10, 2025
@picnixz picnixz changed the title GitHub Actions: pin to windows-22.04 gh-138744: GitHub Actions: pin to windows-22.04 Sep 10, 2025
@hugovk hugovk removed the skip issue label Sep 10, 2025
@hugovk
Copy link
Member Author

hugovk commented Sep 10, 2025

@vstinner vstinner changed the title gh-138744: GitHub Actions: pin to windows-22.04 gh-138744: GitHub Actions: pin to windows-2022 Sep 10, 2025
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a good idea to pin the Windows version and only upgrade it once it's well tested on newer Windows.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pinning is a good idea in any case.

Question: does this new version have os.getpid?

@hugovk
Copy link
Member Author

hugovk commented Sep 10, 2025

Question: does this new version have os.getpid?

Looks like they both do:

@hugovk hugovk merged commit 6e78a53 into python:main Sep 10, 2025
107 of 108 checks passed
@hugovk hugovk deleted the 3.15-pin-windows-2022 branch September 10, 2025 14:28
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2025
(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.13

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138752 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 10, 2025
@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.11

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.10

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6e78a539bfb406238ec251ba01b7a1819e5c303e 3.9

@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138753 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 10, 2025
…GH-138743)

(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 10, 2025
…GH-138743)

(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138754 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 10, 2025
…GH-138743)

(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138755 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 10, 2025
…GH-138743)

(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138757 is a backport of this pull request to the 3.10 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.10 only security fixes label Sep 10, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 10, 2025
…H-138743)

(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 10, 2025

GH-138758 is a backport of this pull request to the 3.9 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.9 only security fixes label Sep 10, 2025
hugovk added a commit that referenced this pull request Sep 10, 2025
ambv pushed a commit that referenced this pull request Sep 13, 2025
ambv pushed a commit that referenced this pull request Sep 13, 2025
…H-138755)

* [3.11] gh-138744: GitHub Actions: pin to `windows-2022` (GH-138743)
(cherry picked from commit 6e78a53)

Co-authored-by: Hugo van Kemenade <[email protected]>

* Update .azure-pipelines/libffi-build.yml
ambv pushed a commit that referenced this pull request Sep 13, 2025
Yhg1s pushed a commit that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra CI, GitHub Actions, buildbots, Dependabot, etc. OS-windows skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants