Skip to content

gh-138714: Don't assume next block has instructions when propagating line numbers #138770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

gh-138714: Don't assume next block has instructions when propagating line numbers #138770

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e087d7
Don't assume next block has instructions
DinoV Sep 10, 2025
fb9ea7e
add test, tweak
iritkatriel Sep 15, 2025
dc677f8
Merge remote-tracking branch 'upstream/main' into dont_assume_instrs
iritkatriel Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Python/flowgraph.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3617,7 +3617,10 @@ propagate_line_numbers(basicblock *entryblock) {
}
if (is_jump(last)) {
basicblock *target = last->i_target;
if (target->b_predecessors == 1) {
while (target->b_iused == 0 && target->b_predecessors == 1) {
target = target->b_next;
}
if (target->b_predecessors == 1 && target->b_iused > 0) {
if (target->b_instr[0].i_loc.lineno == NO_LOCATION.lineno) {
target->b_instr[0].i_loc = prev_location;
}
Expand Down
Loading