Skip to content

gh-137242: Allow Android testbed to take all Python command-line options #138805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2025
Merged

gh-137242: Allow Android testbed to take all Python command-line options #138805

merged 4 commits into from
Oct 6, 2025
+153 −130

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Sep 11, 2025 •
edited
Loading

#138649 and python/buildmaster-config#628 switched GitHub Actions and the buildbots over to using --fast-ci and --slow-ci on Android. However, this has introduced a warning, which has turned the buildbots orange:

Warning -- Failed to change Python options: FileNotFoundError(2, 'No such file or directory')
Warning -- Command: -u -W error -bb --dont-add-python-opts

Android runs the tests embedded in a larger app, so it's not possible to change the Python options by calling execv. Instead, this PR adds the ability to pass all Python command-line options to the Android testbed, so the options can be set to the expected values from the start.

This may also be useful in cibuildwheel, as it'll allow the testbed to accept a wider range of Python test commands (pypa/cibuildwheel#2590).

@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2025
Closed
@mhsmith mhsmith added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 11, 2025
This was referenced Sep 11, 2025
Merged
Draft
emmatyping
emmatyping reviewed Sep 11, 2025
View reviewed changes
freakboy3742
freakboy3742 requested changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly makes sense; a couple of minor clarification questions inline.

@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mhsmith mhsmith mentioned this pull request Sep 19, 2025
Merged
@mhsmith
Copy link
Member Author

mhsmith commented Sep 27, 2025

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Sep 27, 2025

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from freakboy3742 September 27, 2025 16:17
freakboy3742
freakboy3742 requested changes Sep 29, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mhsmith
Copy link
Member Author

mhsmith commented Oct 4, 2025

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Oct 4, 2025

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from freakboy3742 October 4, 2025 15:44
freakboy3742
freakboy3742 approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for those changes (and explanations) - looks like a solid set of improvements.

@freakboy3742 freakboy3742 merged commit a9b0506 into python:main Oct 6, 2025
90 of 95 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
@mhsmith @miss-islington
pythongh-137242: Allow Android testbed to take all Python command-lin…
41e76c0 
…e options (pythonGH-138805)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
(cherry picked from commit a9b0506)

Co-authored-by: Malcolm Smith <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
@mhsmith @miss-islington
pythongh-137242: Allow Android testbed to take all Python command-lin…
99b370d 
…e options (pythonGH-138805)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
(cherry picked from commit a9b0506)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139637 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139638 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2025
freakboy3742 pushed a commit that referenced this pull request Oct 6, 2025
@miss-islington @mhsmith
[3.13] gh-137242: Allow Android testbed to take all Python command-li…
d3a4e06 
…ne options (GH-138805) (#139638)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
(cherry picked from commit a9b0506)

Co-authored-by: Malcolm Smith <[email protected]>
hugovk pushed a commit that referenced this pull request Oct 6, 2025
@miss-islington @mhsmith
[3.14] gh-137242: Allow Android testbed to take all Python command-li…
f776254 
…ne options (GH-138805) (#139637)

Co-authored-by: Malcolm Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatyping emmatyping emmatyping left review comments

@picnixz picnixz picnixz left review comments

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhsmith @freakboy3742 @emmatyping @picnixz