-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-71810: Fix _PyLong_AsByteArray() undefined behavior #138873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Don't read p[-1] when p is an empty string: when n==0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…H-138873) Don't read p[-1] when p is an empty string: when n==0. (cherry picked from commit 8b5ce31) Co-authored-by: Victor Stinner <[email protected]>
…H-138873) Don't read p[-1] when p is an empty string: when n==0. (cherry picked from commit 8b5ce31) Co-authored-by: Victor Stinner <[email protected]>
GH-138883 is a backport of this pull request to the 3.14 branch. |
GH-138884 is a backport of this pull request to the 3.13 branch. |
) (#138884) gh-71810: Fix _PyLong_AsByteArray() undefined behavior (GH-138873) Don't read p[-1] when p is an empty string: when n==0. (cherry picked from commit 8b5ce31) Co-authored-by: Victor Stinner <[email protected]>
|
) (#138883) gh-71810: Fix _PyLong_AsByteArray() undefined behavior (GH-138873) Don't read p[-1] when p is an empty string: when n==0. (cherry picked from commit 8b5ce31) Co-authored-by: Victor Stinner <[email protected]>
Don't read p[-1] when p is an empty string: when n==0.