gh-137065: Revert "gh-105499: Merge typing.Union and types.UnionType (#105511)" #138967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
JelleZijlstra,
AlexWaygood and
rhettinger
as code owners
…s.UnionType (python#105511)" This reverts commit d1db43c. This reverts commit 0f511d8. This reverts commit dc6d66f.
serhiy-storchaka
force-pushed
the
revert-gh-105499
branch
from
efdd228 to
5cd4a72
Compare
|
I agree that this should be reverted. It would be too difficult to change after a release. It looks like concerns were raised from the outset and were not resolved before the PR was applied. |
|
SC decided on the status quo. |
|
Do you mean restoring the status quo? |
|
It is better to merge this PR earlier, because I may need a time to resolve conflicts with 3.14. |
|
Sorry for the ambiguity. I meant keeping 3.14 as is, without this revert. The SC will post their decision later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d1db43c.
This reverts commit 0f511d8.
This reverts commit dc6d66f.
typing._UnionGenericAlias, nottyping.Union#137065📚 Documentation preview 📚: https://cpython-previews--138967.org.readthedocs.build/