Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 16, 2025

@pablogsal
Copy link
Member Author

I will use this later to make the invalid rules non implicit

@pablogsal pablogsal force-pushed the gh-138970 branch 2 times, most recently from f471328 to f55196f Compare September 16, 2025 10:30
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! That's gonna be useful! Left some minor comments.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pablogsal pablogsal merged commit 0ce9fb7 into python:main Sep 18, 2025
55 checks passed
@pablogsal pablogsal deleted the gh-138970 branch September 18, 2025 01:17
@encukou
Copy link
Member

encukou commented Sep 18, 2025

Turns out we only run the tests on Buildbots.
Fix in #139107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants