Skip to content

gh-138970: Adjust tests for pegen rule flags #139107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

gh-138970: Adjust tests for pegen rule flags #139107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d058610
gh-138970: Adjust tests for pegen rule flags
encukou Sep 18, 2025
28117eb
Adjust wording
encukou Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Lib/test/test_peg_generator/test_pegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,24 +1131,28 @@ def test_rule_flags(self) -> None:

# Test memo-only rule
simple_rule = rules['simple_rule']
self.assertTrue(simple_rule.memo, "simple_rule should have memo=True")
self.assertTrue('memo' in simple_rule.flags,
"simple_rule should have memo")
self.assertEqual(simple_rule.flags, frozenset(['memo']),
f"simple_rule flags should be {'memo'}, got {simple_rule.flags}")

# Test multi-flag rule
multi_flag_rule = rules['multi_flag_rule']
self.assertTrue(multi_flag_rule.memo, "multi_flag_rule should have memo=True")
self.assertTrue('memo' in simple_rule.flags,
"multi_flag_rule should have memo")
self.assertEqual(multi_flag_rule.flags, frozenset({'memo', 'custom', 'test'}),
f"multi_flag_rule flags should contain memo, custom, test, got {multi_flag_rule.flags}")

# Test single custom flag rule
single_custom_rule = rules['single_custom_flag']
self.assertFalse(single_custom_rule.memo, "single_custom_flag should have memo=False")
self.assertFalse('memo' not in simple_rule.flags,
"single_custom_flag should not have memo")
self.assertEqual(single_custom_rule.flags, frozenset(['custom']),
f"single_custom_flag flags should be {'custom'}, got {single_custom_rule.flags}")

# Test no flags rule
no_flags_rule = rules['no_flags_rule']
self.assertFalse(no_flags_rule.memo, "no_flags_rule should have memo=False")
self.assertEqual(no_flags_rule.flags, [],
self.assertFalse('memo' not in simple_rule.flags,
"no_flags_rule should not have memo")
self.assertEqual(no_flags_rule.flags, frozenset(),
f"no_flags_rule flags should be the empty set, got {no_flags_rule.flags}")
Loading