Skip to content

gh-135604: Append to .gitignore instead of overwriting it #139130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-135604: Append to .gitignore instead of overwriting it #139130

wants to merge 2 commits into from

Conversation

@pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Sep 18, 2025 •
edited by bedevere-app bot
Loading

@pradyunsg
Append to .gitignore instead of overwriting it
c4abc31 
Help ensure that the `.gitignore` file is not destroyed, if an
environment is created in a directory that already exists.
@python-cla-bot
Copy link

python-cla-bot bot commented Sep 18, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Sep 18, 2025
Open
@FFY00
Copy link
Member

FFY00 commented Oct 4, 2025

Appending like this will keep blindly adding * to the file each time the venv is constructed, no? Couldn't we check if the file exists and does not include * already first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pradyunsg @FFY00