Skip to content

Conversation

@cmaloney
Copy link
Contributor

@cmaloney cmaloney commented Sep 19, 2025

These tests take 1.3 seconds on my dev machine, match fairly closely with testing textio.c implementation only.


I'm only planning one more split to these tests after this, finally moving the buffered out of test_general. Timings with -uall,largefile,extralargefile,walltime -M12G

- test_io.test_signals: 24.2 sec
- test_io.test_largefile: 10.0 sec
- test_io.test_general: 8.9 sec
- test_io.test_textio: 1.3 sec
- test_io.test_fileio: 375 ms
- test_io.test_bufferedio: 293 ms
- test_io.test_file: 87 ms
- test_io.test_memoryio: 56 ms
- test_io.test_univnewlines: 31 ms

These tests take 1.3 seconds on my dev machine, match fairly closely
with testing `textio.c` implementation only.
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 19, 2025
@cmaloney cmaloney changed the title gh-138013: Split TextIO tests from test_general gh-138013: Split TextIO tests from testtest_general Sep 19, 2025
@cmaloney cmaloney changed the title gh-138013: Split TextIO tests from testtest_general gh-138013: Split TextIO tests from test_io.test_general Sep 19, 2025
@cmaloney
Copy link
Contributor Author

cc: @vstinner (only one more to go after this than test_io split will be done)

@vstinner vstinner merged commit f752fde into python:main Sep 30, 2025
43 checks passed
@vstinner
Copy link
Member

Merged, thank you.

@cmaloney cmaloney deleted the split_textio branch October 1, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants