Skip to content

gh-138709: Supress stdout/stderr during test_sampling_profiler tests #139212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2025
Merged

gh-138709: Supress stdout/stderr during test_sampling_profiler tests #139212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Lib/test/test_profiling/test_sampling_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from test.support import force_not_colorized_test_class, SHORT_TIMEOUT
from test.support.socket_helper import find_unused_port
from test.support import requires_subprocess, is_emscripten
from test.support import captured_stdout, captured_stderr

PROCESS_VM_READV_SUPPORTED = False

Expand Down Expand Up @@ -416,7 +417,8 @@ def test_collapsed_stack_collector_export(self):
collector.collect(test_frames2)
collector.collect(test_frames3)

collector.export(collapsed_out.name)
with (captured_stdout(), captured_stderr()):
collector.export(collapsed_out.name)
# Check file contents
with open(collapsed_out.name, "r") as f:
content = f.read()
Expand Down Expand Up @@ -500,7 +502,8 @@ def test_flamegraph_collector_export(self):
collector.collect(test_frames3)

# Export flamegraph
collector.export(flamegraph_out.name)
with (captured_stdout(), captured_stderr()):
collector.export(flamegraph_out.name)

# Verify file was created and contains valid data
self.assertTrue(os.path.exists(flamegraph_out.name))
Expand Down Expand Up @@ -1918,7 +1921,7 @@ def test_valid_output_formats(self):
self.addCleanup(shutil.rmtree, tempdir.name)


with contextlib.chdir(tempdir.name):
with (contextlib.chdir(tempdir.name), captured_stdout(), captured_stderr()):
for fmt in valid_formats:
try:
# This will likely fail with permissions, but the format should be valid
Expand Down Expand Up @@ -2632,6 +2635,7 @@ def test_gil_mode_collector_configuration(self):
with (
mock.patch("profiling.sampling.sample.SampleProfiler") as mock_profiler,
mock.patch("profiling.sampling.sample.PstatsCollector") as mock_collector,
captured_stdout(), captured_stderr()
):
# Mock the profiler instance
mock_instance = mock.Mock()
Expand Down
Loading