-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-101100: Fix some Sphinx reference warnings in whatsnew/2.6.rst #139236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AA-Turner
merged 11 commits into
python:main
from
rowanbudge:fix-sphinx-warnings-in-whatsnew-2.6
Oct 4, 2025
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5eb56d1
Ignore future_builtins
rowanvil d8f9ee0
Ignore sys.py3kwarning
rowanvil 03605c4
Make example code reference literals for DatabaseConnection and Drawable
rowanvil dd87800
fix contextlib references
rowanvil e65c236
fix multiprocessing references
rowanvil 82dfad3
Fix New I/O Library refernces
rowanvil b47e279
Fix Abstract Base Classes references
rowanvil c8b77ec
Ignore APPDATA
rowanvil 3c94412
Review Changes - Wrap lines v2
rowanvil 3c96755
Fix Unexpected indentation Warning
rowanvil 53b1682
Tweaks
AA-Turner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wrap lines to 79 characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've wrapped at 79 lines in all the places already edited by this PR that I could spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, however, it introduced a lot of trailing white space causing the lint CI to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep aware and working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks now pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, rewrapping all edits makes it harder to review the actual changes in the diff, so it's a balance. (There's some discussion in python/devguide#1018.)
No need to unwrap though.
Also please avoid force-pushing -- everything gets squashed into a single commit at the end, and separate commits are easier to review. Thanks!