Skip to content

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Sep 22, 2025

As @encukou pointed out, running make twice after merging #139170 resulted in an unnecessary recompile. I believe this is because of a redundant assignment of JIT_STENCILS_H.

@savannahostrowski
Copy link
Member Author

!buildbot FreeBSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @savannahostrowski for commit 9e4b457 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139241%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD PR
  • AMD64 FreeBSD14 PR

@savannahostrowski
Copy link
Member Author

!buildbot FreeBSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @savannahostrowski for commit 70d5a56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139241%2Fmerge

The command will test the builders whose names match following regular expression: FreeBSD

The builders matched are:

  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD PR
  • AMD64 FreeBSD14 PR

@savannahostrowski
Copy link
Member Author

@encukou Did you want to take a look at this one?

@encukou
Copy link
Member

encukou commented Oct 1, 2025

Sorry, I missed the notification!

Unfortunately this doesn't solve the issue for me. In my config, REGEN_JIT_COMMAND is empty, so a jit_stencils.h is never created, but make attempts to create it and recreates its dependents (jit_stencils.hPython/jit.oPrograms/_freeze_module → frozen modules).

@savannahostrowski
Copy link
Member Author

savannahostrowski commented Oct 2, 2025

Okay, I think that removing the literal jit_stencils.h dependency fixes this. This should also still work just fine to solve the original problem since the platform-specific stencils always exist alongside jit_stencils.h.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did it. Thank you!

@savannahostrowski savannahostrowski merged commit 9964320 into python:main Oct 5, 2025
43 checks passed
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants