-
-
Notifications
You must be signed in to change notification settings - Fork 33k
GH-137218: Fix unnecessary recompile of Programs/_freeze_module
#139241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-137218: Fix unnecessary recompile of Programs/_freeze_module
#139241
Conversation
!buildbot FreeBSD |
🤖 New build scheduled with the buildbot fleet by @savannahostrowski for commit 9e4b457 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139241%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot FreeBSD |
🤖 New build scheduled with the buildbot fleet by @savannahostrowski for commit 70d5a56 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139241%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
@encukou Did you want to take a look at this one? |
Sorry, I missed the notification! Unfortunately this doesn't solve the issue for me. In my config, |
Okay, I think that removing the literal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That did it. Thank you!
As @encukou pointed out, running
make
twice after merging #139170 resulted in an unnecessary recompile. I believe this is because of a redundant assignment ofJIT_STENCILS_H
._pyrepl
with low value forJUMP_BACKWARD_INITIAL_VALUE
#137218