Skip to content

gh-139276: Remove generator type check in _testcapimodule.c:raise_SIGINT_then_send_None #139252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2025
Merged

gh-139276: Remove generator type check in _testcapimodule.c:raise_SIGINT_then_send_None #139252

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5292200
Remove generator type check in raise_SIGINT_then_send_None
jbower-fb Sep 22, 2025
61543b3
Also stop using PyGenObject type
jbower-fb Sep 24, 2025
c8ebaee
Merge branch 'main' into removetypecheck
jbower-fb Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Modules/_testcapimodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,9 +1583,9 @@ getitem_with_error(PyObject *self, PyObject *args)
static PyObject *
raise_SIGINT_then_send_None(PyObject *self, PyObject *args)
{
PyGenObject *gen;
PyObject *gen;

if (!PyArg_ParseTuple(args, "O!", &PyGen_Type, &gen))
if (!PyArg_ParseTuple(args, "O", &gen))
return NULL;

/* This is used in a test to check what happens if a signal arrives just
Expand All @@ -1599,7 +1599,7 @@ raise_SIGINT_then_send_None(PyObject *self, PyObject *args)
because we check for signals before every bytecode operation.
*/
raise(SIGINT);
return PyObject_CallMethod((PyObject *)gen, "send", "O", Py_None);
return PyObject_CallMethod(gen, "send", "O", Py_None);
}


Expand Down
Loading