-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-139269: Fix unaligned memory access in JIT code patching functions #139271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashm-dev
wants to merge
17
commits into
python:main
Choose a base branch
from
ashm-dev:gh-139269
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+25
−11
Open
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2f49286
Use memcpy for patching values instead of direct assignment
ashm-dev f6765ba
Add news entry for JIT unaligned store fix in patch_* functions
ashm-dev b036772
Merge branch 'main' into gh-139269
ashm-dev c45d0cc
Remove unused local variables from patch functions
ashm-dev cf3c01b
Merge remote-tracking branch 'upstream/main' into gh-139269
ashm-dev 827aa7e
Merge branch 'main' into gh-139269
ashm-dev 684ff40
Fix UB in JIT patch_* functions with unaligned store
ashm-dev 2c1339b
Merge remote-tracking branch 'upstream/main' into gh-139269
ashm-dev b5a8686
Update Misc/NEWS.d/next/Core_and_Builtins/2025-09-23-21-01-12.gh-issu…
ashm-dev d266ac0
Merge remote-tracking branch 'upstream/main' into gh-139269
ashm-dev f075c91
Merge branch 'main' into gh-139269
ashm-dev d19cf62
Use memcpy in set_bits to avoid alignment issues
ashm-dev c2cf365
Merge remote-tracking branch 'upstream/main' into gh-139269
ashm-dev c36c2b7
Merge branch 'main' into gh-139269
ashm-dev 1e35b61
Track global and builtins dependencies for LOAD_GLOBAL
ashm-dev 3f327a5
Merge branch 'main' into gh-139269
ashm-dev 39bcc4c
Remove comments marking proposed fix in LOAD_GLOBAL case
ashm-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2025-09-23-21-01-12.gh-issue-139269.1rIaxy.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
JIT: UB: unaligned store in patch_* functions | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.