gh-67795: Improve precision of non-float timestamp and timeout arguments #139273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
pganssle,
abalkin and
AA-Turner
as code owners
…arguments Use the as_integer_ratio() or the numerator and denominator attributes to represent the number as an integer ratio and perform scaling and rounding exactly. This allows to avoid the precision loss and double rounding error due to conversion to float.
serhiy-storchaka
force-pushed
the
timestamp-timeout-as-integer-ratio
branch
from
5672976 to
90f8bf2
Compare
vstinner
reviewed
Oct 3, 2025
| } | ||
|
|
||
|
|
||
| static int |
There was a problem hiding this comment.
Can you please document the 3 return values (-1, 0, 1)?
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the as_integer_ratio() or the numerator and denominator attributes to represent the number as an integer ratio and perform scaling and rounding exactly.
This allows to avoid the precision loss and double rounding error due to conversion to float.
📚 Documentation preview 📚: https://cpython-previews--139273.org.readthedocs.build/