-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
(3.13) Fixes: (workflow) syntax problem and specified explicit Python… #139300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… version number 3.13 Signed-off-by: ioit-aaa <[email protected]>
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I contributed this PR simply because the broken workflow was distracting me from playing Genshin Impact. I kept wondering why the syntax error hadn’t been fixed yet, and the Python version was still unspecified. I guess I’m just a bit of a perfectionist. |
ince this workflow is tied to the |
I don't think it's an issue. We can have an empty |
The workflow is not tied to Python 3.13. This is a workflow for checking wheels, so it doesn't matter which Python is used, as soon as the latter is compatible with the script. |
I understand that the script may run fine on any compatible Python version, but since this workflow lives on the 3.13 branch, explicitly pinning Python 3.13 helps reinforce semantic clarity and avoids ambiguity in future maintenance. |
The workflow lives in every branch. It doesn't help future maintenance as we'll need to change each branch with the corresponding Python version and backport this, which is extra work. Some workflows need specific Python versions because of the script they use though and this is fine. But this one doesn't need Python 3.13 explicitly and it's better to use the default Python of the image. |
Thank you for your explanation |
… version number 3.13
This PR fixes a workflow syntax error and pins the Python version to 3.13 to ensure compatibility with future releases.
It addresses a failure in
.github/workflows/verify-ensurepip-wheels.yml
caused by an invalid workflow_dispatch declaration.