-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-139349: fix init dataclass Console init with value ignore repr error #139351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yihong0618 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should use Console
before prepare()
has been called. Thus, this should likely not be fixed like that.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Signed-off-by: yihong0618 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the console interface is a private implementation detail (_pyrepl
is private and _pyrepl.readline._wrapper.reader
is even more private, so no one should directly access it; if one incorrectly uses UnixConsole(), then something wrong may happen). I am still unconvinced that we should do anything here. I'll let @pablogsal or @ambv decide on the course of action here (though just removing console
from the repr
might be fine; however no NEWS should be added IMO).
Signed-off-by: yihong0618 <[email protected]>
init it with default value to avoid repr error