Skip to content

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Sep 26, 2025

There were some typos that slipped under both @hartwork's and my radar and some functions that could be made more generic and used by the next PR.


📚 Documentation preview 📚: https://cpython-previews--139366.org.readthedocs.build/

Copy link
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@picnixz looks alright with me 👍

@picnixz
Copy link
Member Author

picnixz commented Sep 26, 2025

Oh thank you for the review. I pinged you on the wrong PR but you saw this one. Thanks!

@picnixz picnixz enabled auto-merge (squash) September 26, 2025 16:36
@picnixz
Copy link
Member Author

picnixz commented Sep 26, 2025

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@hartwork
Copy link
Contributor

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@picnixz sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker. Is that what you meant?

@picnixz
Copy link
Member Author

picnixz commented Sep 26, 2025

sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker

yes, I don't know if cherry-picker can do multiple cherry-picks actually

@picnixz
Copy link
Member Author

picnixz commented Sep 26, 2025

Mmh, TSAN is taking an incredibly long time.

@picnixz picnixz merged commit 68a1778 into python:main Sep 26, 2025
81 of 83 checks passed
@picnixz picnixz deleted the feat/xml/post-139234 branch September 26, 2025 18:16
hartwork pushed a commit to hartwork/cpython that referenced this pull request Sep 26, 2025
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 28, 2025
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 2, 2025
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 2, 2025
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 3, 2025
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants