Skip to content

GH-139193: Fix dump_stack when PYTHON_LLTRACE=4 #139384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GH-139193: Fix dump_stack when PYTHON_LLTRACE=4 #139384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0ff9f8
Fix PyStackRef_IsError for gil-enabled build
sergey-miryanov Sep 27, 2025
0780c36
Fix dump_item to check is the item valid or no
sergey-miryanov Sep 27, 2025
58b4564
Fix PyStackRef_IsValid accordingly
sergey-miryanov Sep 28, 2025
86be53d
Revert "Fix PyStackRef_IsValid accordingly"
sergey-miryanov Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Include/internal/pycore_stackref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ PyStackRef_Unwrap(_PyStackRef ref)
static inline bool
PyStackRef_IsError(_PyStackRef ref)
{
return ref.bits == Py_TAG_INVALID;
return (ref.bits & Py_TAG_BITS) == Py_TAG_INVALID;
}

static inline bool
Expand Down
4 changes: 4 additions & 0 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ dump_item(_PyStackRef item)
printf("<NULL>");
return;
}
if (PyStackRef_IsError(item)) {
printf("<INVALID>");
return;
}
if (PyStackRef_IsTaggedInt(item)) {
printf("%" PRId64, (int64_t)PyStackRef_UntagInt(item));
return;
Expand Down
Loading