-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-99453: improve entries validation of Netscape/Mozilla cookie files #139395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paul-Ramshaw
wants to merge
11
commits into
python:main
Choose a base branch
from
Paul-Ramshaw:gh-99453-fix-mozillacookiejar-loaderror
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8890d15
Validate Netscape cookie lines have 7 fields to avoid uncaught ValueE…
Paul-Ramshaw 11f780b
cookiejar: add NEWS entry for gh-99453
Paul-Ramshaw fde62a6
Add to ACKS
Paul-Ramshaw 81c5d25
Fix typo in ACKS
Paul-Ramshaw 20422f1
Fix NEWS entry formatting
Paul-Ramshaw 106be5f
Remove trailing whitespace from test_http_cookiejar.py
Paul-Ramshaw 135c90e
test_http_cookiejar: improve malformed cookie file test
Paul-Ramshaw b701221
cookiejar: wrap error message to 80 characters
Paul-Ramshaw 97daafe
NEWS: adjust http.cookiejar entry markup
Paul-Ramshaw 8ea2ad8
ACKS: fix alphabetical order
Paul-Ramshaw 1837806
test_http_cookiejar: remove trailing whitespace from blank line
Paul-Ramshaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-09-28-12-52-40.gh-issue-99453.qJBIf-.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
**http.cookiejar**: Netscape/Mozilla cookie files with malformed lines now | ||
raise :exc:`LoadError` instead of an uncaught :exc:`ValueError`. | ||
picnixz marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.