-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-139322: Create test_os package #139453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Move test_posix.py and test_os.py to Lib/test/test_os/ * Split Windows specific test cases to a new test_windows.py file.
@serhiy-storchaka: Here is a simpler approach which only creates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were is test_windows?
Ooops, I forgot git add :-) Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Win32ErrorTests may be removed if all its tests are duplicated in other places for all platforms.
from .utils import create_file | ||
|
||
|
||
class Win32ErrorTests(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, these tests were for WindowsError. But now OSError is raised on all platforms. These tests are no longer Windows specific, and most likely are duplicated in other parts.
Please check that all these functions are already tested with non-existing file (and mkdir()
with an existing file). Then they can be deleted.
Merged, thanks for the review.
Good catch! I created #139477 to remove |
Uh oh!
There was an error while loading. Please reload this page.