gh-127068: default REPL where prompts containing newlines would be dup #139465
+33
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <[email protected]>
yihong0618
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
kemingy
reviewed
Oct 1, 2025
Lib/_pyrepl/reader.py
Outdated
| del screeninfo[num_common_lines:] | ||
|
|
||
| last_refresh_line_end_offsets = self.last_refresh_cache.line_end_offsets | ||
| last_refresh_line_end_offsets = self.last_refresh_cache.line_end_offsets.copy() |
There was a problem hiding this comment.
It seems this last_refresh_line_end_offsets has never been used in this function. The bug can be fixed by deleting this one.
The other two screen & screeninfo are synced back to self.last_refresh_cache. But for readability & maintenance, we should copy them here.
|
The failed Windows test ( If we add the - (4, 2)
+ (2, 3) : [(0, [1, 1, 1, 1, 1]), (0, [1, 1, 1, 1, 1]), (0, [1, 2, 1])] |
Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Keming <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
picnixz
reviewed
Oct 1, 2025
Signed-off-by: yihong0618 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the this lis the calc_screen() method of reader.py. When screen, screeninfo, and line_end_offsets are retrieved from the cache, they are passed by direct reference instead of by a copy.
before this patch
2025-10-01.12.31.25.mov
after this patch
2025-10-01.12.57.17.mov