Skip to content

gh-135125: Fix Py_STACKREF_DEBUG build #139475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2025
Merged

gh-135125: Fix Py_STACKREF_DEBUG build #139475

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0ea1b1
Fixes for PyStackRefs in debug builds.
efimov-mikhail Oct 1, 2025
56a2076
The same pattern of refcounting for stackrefs as in production build
efimov-mikhail Oct 3, 2025
89cd750
Merge branch 'main' into issue_135379_stackref_debug_fixes
efimov-mikhail Oct 22, 2025
a2754b7
Adoption after merge main, review addressed
efimov-mikhail Oct 22, 2025
14b89e5
Address review
efimov-mikhail Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Include/internal/pycore_stackref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,19 @@ static const _PyStackRef PyStackRef_ERROR = { .index = 2 };

#define INITIAL_STACKREF_INDEX 10

static inline _PyStackRef
PyStackRef_Wrap(void *ptr)
{
assert(ptr != NULL);
return (_PyStackRef){ .index = (uint64_t)ptr };
}

static inline void *
PyStackRef_Unwrap(_PyStackRef ref)
{
return (void *)(ref.index);
}

static inline int
PyStackRef_IsNull(_PyStackRef ref)
{
Expand Down Expand Up @@ -151,6 +164,7 @@ _PyStackRef_FromPyObjectSteal(PyObject *obj, const char *filename, int linenumbe
static inline _PyStackRef
_PyStackRef_FromPyObjectBorrow(PyObject *obj, const char *filename, int linenumber)
{
Py_INCREF(obj);
return _Py_stackref_create(obj, filename, linenumber);
}
#define PyStackRef_FromPyObjectBorrow(obj) _PyStackRef_FromPyObjectBorrow(_PyObject_CAST(obj), __FILE__, __LINE__)
Expand Down
Loading