Skip to content

gh-139478: Add warning about lack of validation for xml.sax.saxutils.XMLGenerator #139479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −0
Open

gh-139478: Add warning about lack of validation for xml.sax.saxutils.XMLGenerator #139479

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1e4e12
Add warning about lack of validation for `xml.sax.saxutils.XMLGenerator`
sethmlarson Oct 1, 2025
87080f7
Commit suggestion from code review
sethmlarson Oct 1, 2025
e845206
Commit suggestion from code review
sethmlarson Oct 1, 2025
4b4c15a
Move warning to be after description
sethmlarson Oct 1, 2025
cbe0c12
Change security warning to note about intended usage
sethmlarson Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Doc/library/xml.sax.utils.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ or as base classes.
content: if ``False`` (the default) they are emitted as a pair of start/end
tags, if set to ``True`` they are emitted as a single self-closed tag.

.. warning::
:class:`!XMLGenerator` does not validate element or
attribute names. Callers must ensure that names passed to APIs conform
to `XML name rules <https://www.w3.org/TR/xml/#NT-Name>`__ if passing
untrusted input. Character data and attribute values are escaped,
but not validated.

.. versionchanged:: 3.2
Added the *short_empty_elements* parameter.

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Documentation/2025-10-01-10-06-52.gh-issue-139478.AdnsbB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:mod:`xml.sax.saxutils`: Add warning about lack of
validation for :class:`~xml.sax.saxutils.XMLGenerator`.
Loading