Skip to content

gh-139482: speed up os.environ.clear by 2x #139483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

gh-139482: speed up os.environ.clear by 2x #139483

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
850a898
Make environ.clear() asymptotically efficient (O(N^2) -> O(N)).
gukoff Oct 1, 2025
7248570
Add NEWS entry
gukoff Oct 1, 2025
67cc140
Account for key encoding
gukoff Oct 1, 2025
8c1ca20
Update Misc/NEWS.d/next/Library/2025-10-01-17-45-27.gh-issue-139482.y…
gukoff Oct 1, 2025
e116604
Add unit tests
gukoff Oct 2, 2025
56718b4
Fix comments
gukoff Oct 2, 2025
655d2c5
Merge remote-tracking branch 'origin/main' into efficient-clearenv
gukoff Oct 2, 2025
c3390e3
remote trailing whitespace
gukoff Oct 2, 2025
b348afa
remove newlines
gukoff Oct 11, 2025
be5b530
Merge remote-tracking branch 'origin/main' into efficient-clearenv
gukoff Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,15 @@ def __repr__(self):
)
return f"environ({{{formatted_items}}})"

def clear(self):
while self._data:
for key in list(self._data):
unsetenv(key)
try:
del self._data[key]
except KeyError:
pass

def copy(self):
return dict(self)

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-10-01-17-45-27.gh-issue-139482.yDMeEa.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Make os.environ.clear() more efficient (linear complexity instead of quadratic)

Loading