gh-139525: Don't specialize functions which have a modified vectorcall #139524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
force-pushed
the
dont_specialize_vectorcall
branch
2 times, most recently
from
da9f886 to
4e30d66
Compare
DinoV
changed the title
DinoV
force-pushed
the
dont_specialize_vectorcall
branch
from
797814b to
9a4d5b0
Compare
danigm
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Oct 7, 2025
…torcall (python#139524) Don't specialize functions which have a modified vectorcall
|
Thanks @DinoV for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @DinoV, I could not cleanly backport this to |
DinoV
added a commit
to DinoV/cpython
that referenced
this pull request
Oct 7, 2025
…torcall (python#139524) Don't specialize functions which have a modified vectorcall
|
GH-139709 is a backport of this pull request to the 3.14 branch. |
DinoV
added a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specializer isn't checking to see if
vectorcallis overridden, but the interpreter loop does. This causes a call which goes through this to randomly go through the interpreter on the first specialization, and then it de-opts and goes through vectorcall.