Skip to content

Conversation

aureliobarbosa
Copy link
Contributor

@aureliobarbosa aureliobarbosa commented Oct 3, 2025

gh-139533: fix refs to code without proper markups on turtledemo doc

Many references to scripts and functions on turtledemo module documentation do not use the proper reStructuredText markups used on this repo. This PR fixes them.


📚 Documentation preview 📚: https://cpython-previews--139534.org.readthedocs.build/

+------------------------+------------------------------+--------------------------------------+
| Name | Description | Features |
+========================+==============================+======================================+
| ``bytedesign`` | complex classical | :func:`tracer`, :func:`delay`, |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:mod: role seems to be more suitable for this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bytedesign? It is a file in a module, not a module. Since it has no documentation, the rendered result will be the same anyway. I guess :source:`bytedesign <Lib/turtledemo/bytedesign.py>` would make sense, but I think the current one is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a module in a package, isn't it?

However, I haven't thought about the effects of :mod: at a module without documentation. I like the idea of making it easier to access source code. As demonstration scripts, it is natural that people want to see the code, particularly in educational contexts where the turtle is widely used

Copy link
Contributor

@adorilson adorilson Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion about :mod: is also, although sticks (``) are used on variables/literals/code, :mod: is a bigger warning saying "don't translate it". This issue arose from a discussion on this point. Is there something to this case? A role that escapes the string from the translation process?

@aureliobarbosa aureliobarbosa force-pushed the doc_turtledemo_table_issues branch from febfc34 to a8985a9 Compare October 3, 2025 15:42
@StanFromIreland
Copy link
Member

Please don't force push, it makes reviewing more difficult.

@aureliobarbosa
Copy link
Contributor Author

Please don't force push, it makes reviewing more difficult.
Sorry for the force push. Is there anything else to be done on my side?

@StanFromIreland
Copy link
Member

Nope, you just have to wait now. There is a long queue of PRs before this one I’m afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants