-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-139533: fix refs to code without proper markups on turtledemo doc #139534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-139533: fix refs to code without proper markups on turtledemo doc #139534
Conversation
+------------------------+------------------------------+--------------------------------------+ | ||
| Name | Description | Features | | ||
+========================+==============================+======================================+ | ||
| ``bytedesign`` | complex classical | :func:`tracer`, :func:`delay`, | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:mod: role seems to be more suitable for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For bytedesign
? It is a file in a module, not a module. Since it has no documentation, the rendered result will be the same anyway. I guess :source:`bytedesign <Lib/turtledemo/bytedesign.py>`
would make sense, but I think the current one is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a module in a package, isn't it?
However, I haven't thought about the effects of :mod: at a module without documentation. I like the idea of making it easier to access source code. As demonstration scripts, it is natural that people want to see the code, particularly in educational contexts where the turtle is widely used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion about :mod: is also, although sticks (``) are used on variables/literals/code, :mod: is a bigger warning saying "don't translate it". This issue arose from a discussion on this point. Is there something to this case? A role that escapes the string from the translation process?
febfc34
to
a8985a9
Compare
Please don't force push, it makes reviewing more difficult. |
|
Nope, you just have to wait now. There is a long queue of PRs before this one I’m afraid. |
gh-139533: fix refs to code without proper markups on turtledemo doc
Many references to scripts and functions on turtledemo module documentation do not use the proper reStructuredText markups used on this repo. This PR fixes them.
📚 Documentation preview 📚: https://cpython-previews--139534.org.readthedocs.build/