-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-139531: Fix TypeError in inspect.getframeinfo when lineno is None #139535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
PrinceNaroliya
wants to merge
9
commits into
python:main
from
PrinceNaroliya:fix/inspect-getframeinfo-lineno-None
Closed
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b96cc9
Fix: guard added to inspect.getframeinfo to prevent TypeError when li…
PrinceNaroliya 92e87c2
Add NEWS entry for bpo-139531 fix
PrinceNaroliya 24361e4
Add NEWS entry for bpo-139531 fix
PrinceNaroliya e74e210
Add NEWS entry for bpo-139531 fix
PrinceNaroliya fb3b712
Add blank line at the end
PrinceNaroliya d333123
📜🤖 Added by blurb_it.
blurb-it[bot] 574461d
Fix lint, trailing whitespace, and end-of-file issues
PrinceNaroliya 1c831c3
Merge branch 'fix/inspect-getframeinfo-lineno-None' of https://github…
PrinceNaroliya c1a282b
Fix getframeinfo TypeError, add NEWS entry
PrinceNaroliya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,8 @@ | |
| import unittest.mock | ||
| import warnings | ||
| import weakref | ||
| import inspect | ||
| import sys | ||
|
|
||
|
|
||
| try: | ||
|
|
@@ -6250,3 +6252,18 @@ def f(): | |
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
|
|
||
| def test_getframeinfo_with_exceptiongroup(): | ||
|
||
| code = """ | ||
| try: | ||
| 1/0 | ||
| except* Exception: | ||
| raise | ||
| """ | ||
| try: | ||
| exec(code) | ||
| except: | ||
| tb = sys.exc_info()[2] | ||
| while tb: | ||
| info = inspect.getframeinfo(tb.tb_frame) | ||
| tb = tb.tb_next | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? it might happen that lineno is None and should remains so.