Skip to content

gh-127305: more detailed doc for register_error's error_handler #139554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

gh-127305: more detailed doc for register_error's error_handler #139554

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fe011b
gh-127305: more detailed doc for `register_error`'s error_handler
litlighilit Oct 4, 2025
150aa41
fixup! gh-127305: more detailed doc for `register_error`'s error_handler
litlighilit Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Doc/library/codecs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,10 @@ handler:
where encoding should continue. The replacement may be either :class:`str` or
:class:`bytes`. If the replacement is bytes, the encoder will simply copy
them into the output buffer. If the replacement is a string, the encoder will
encode the replacement. Encoding continues on original input at the
specified position. Negative position values will be treated as being
encode the replacement with the ``'strict'`` error handling, which means
:exc:`UnicodeEncodeError` may be raised here.
Encoding continues on originalinput at the specified position.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Encoding continues on originalinput at the specified position.
Encoding continues on original input at the specified position.

Typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may i amend and force push?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do amend, though please avoid force pushing, it makes reviewing more difficult.

Negative position values will be treated as being
relative to the end of the input string. If the resulting position is out of
bound an :exc:`IndexError` will be raised.

Expand Down
Loading