-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-133210: Fix test_inspect
without docstrings
#139651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I've checked this test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I confirm that test_inspect pass on Python built without docstrings.
Since #137862 was backported to 3.13 and 3.14 I am also backporting. Thanks everyone! |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit 7c70cc5c23971ef448ea59827c6e6ae310157356) Co-authored-by: sobolevn <[email protected]>
Sorry, @sobolevn, I could not cleanly backport this to
|
GH-139670 is a backport of this pull request to the 3.13 branch. |
3.14 did not merge this yet. I will wait for it and create a backprot afterwards. |
…139670) gh-133210: Fix `test_inspect` without docstrings (GH-139651) (cherry picked from commit 7c70cc5) Co-authored-by: sobolevn <[email protected]>
--without-doc-strings
#133210