Skip to content

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 6, 2025

Copy link
Contributor

@efimov-mikhail efimov-mikhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I've checked this test locally

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm that test_inspect pass on Python built without docstrings.

@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2025

Since #137862 was backported to 3.13 and 3.14 I am also backporting.

Thanks everyone!

@sobolevn sobolevn merged commit 7c70cc5 into python:main Oct 6, 2025
53 checks passed
@sobolevn sobolevn added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 6, 2025
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
(cherry picked from commit 7c70cc5c23971ef448ea59827c6e6ae310157356)

Co-authored-by: sobolevn <[email protected]>
@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7c70cc5c23971ef448ea59827c6e6ae310157356 3.14

@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139670 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2025
@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2025

3.14 did not merge this yet. I will wait for it and create a backprot afterwards.

sobolevn added a commit that referenced this pull request Oct 6, 2025
…139670)

gh-133210: Fix `test_inspect` without docstrings (GH-139651)
(cherry picked from commit 7c70cc5)

Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge needs backport to 3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants