Skip to content

gh-133210: Fix test_inspect without docstrings #139651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

gh-133210: Fix test_inspect without docstrings #139651

merged 1 commit into from
Oct 6, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 6, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from vstinner October 6, 2025 11:12
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Oct 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 6, 2025
Closed
efimov-mikhail
efimov-mikhail approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@efimov-mikhail efimov-mikhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I've checked this test locally

vstinner
vstinner approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm that test_inspect pass on Python built without docstrings.

@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2025

Since #137862 was backported to 3.13 and 3.14 I am also backporting.

Thanks everyone!

@sobolevn sobolevn merged commit 7c70cc5 into python:main Oct 6, 2025
53 checks passed
@sobolevn sobolevn added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 6, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
@sobolevn @miss-islington
pythongh-133210: Fix test_inspect without docstrings (pythonGH-139651)
38c4eeb 
(cherry picked from commit 7c70cc5)

Co-authored-by: sobolevn <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Sorry, @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7c70cc5c23971ef448ea59827c6e6ae310157356 3.14

@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139670 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2025
@sobolevn
Copy link
Member Author

sobolevn commented Oct 6, 2025

3.14 did not merge this yet. I will wait for it and create a backprot afterwards.

@sobolevn sobolevn mentioned this pull request Oct 6, 2025
Merged
sobolevn added a commit that referenced this pull request Oct 6, 2025
@miss-islington @sobolevn
[3.13] gh-133210: Fix test_inspect without docstrings (GH-139651) (#…
7816ac3 
…139670)

gh-133210: Fix `test_inspect` without docstrings (GH-139651)
(cherry picked from commit 7c70cc5)

Co-authored-by: sobolevn <[email protected]>
@vstinner
Copy link
Member

vstinner commented Oct 6, 2025 •
edited
Loading

3.14 did not merge this yet. I will wait for it and create a backprot afterwards.

There are 4 inspect changes waiting to be merged in 3.14 after 3.14.0 will be released: https://github.com/python/cpython/pulls?q=is%3Aopen+is%3Apr+author%3Amiss-islington+inspect+

danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@sobolevn @danigm
pythongh-133210: Fix test_inspect without docstrings (python#139651)
ce11132
@vstinner vstinner added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Oct 8, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 8, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@sobolevn @miss-islington
pythongh-133210: Fix test_inspect without docstrings (pythonGH-139651)
86d198f 
(cherry picked from commit 7c70cc5)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2025

GH-139776 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
vstinner pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @sobolevn
[3.14] gh-133210: Fix test_inspect without docstrings (GH-139651) (#…
d8bdc1e 
…139776)

gh-133210: Fix `test_inspect` without docstrings (GH-139651)
(cherry picked from commit 7c70cc5)

Co-authored-by: sobolevn <[email protected]>
nairtorres2021-debug

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes

+1 more reviewer

@nairtorres2021-debug nairtorres2021-debug nairtorres2021-debug left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sobolevn sobolevn

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @vstinner @efimov-mikhail @nairtorres2021-debug