gh-139748: fix leaks in AC error paths when using FS-based converters #139765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
requested review from
AA-Turner,
ericsnowcurrently,
erlend-aasland and
gpshead
as code owners
picnixz
force-pushed
the
fix/leak/compile-139748
branch
2 times, most recently
from
3478a0a to
42bead3
Compare
|
Why weren't/aren't these refleaks caught by the refleak buildbots? A |
picnixz
added
needs backport to 3.13
|
picnixz
force-pushed
the
fix/leak/compile-139748
branch
3 times, most recently
from
a24bf3b to
9f89608
Compare
Only tests for functions that effectively leak on error paths are added.
picnixz
force-pushed
the
fix/leak/compile-139748
branch
from
9f89608 to
bf3d10d
Compare
kumaraditya303
approved these changes
Oct 8, 2025
|
Thanks @picnixz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @picnixz and @kumaraditya303, I could not cleanly backport this to |
|
Sorry, @picnixz and @kumaraditya303, I could not cleanly backport this to |
kumaraditya303
pushed a commit
to kumaraditya303/cpython
that referenced
this pull request
Oct 8, 2025
…e FS-based converters (pythonGH-139765) (cherry picked from commit b04a57d) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-139789 is a backport of this pull request to the 3.14 branch. |
kumaraditya303
pushed a commit
to kumaraditya303/cpython
that referenced
this pull request
Oct 8, 2025
…e FS-based converters (pythonGH-139765) (cherry picked from commit b04a57d) Co-authored-by: Bénédikt Tran <[email protected]>
kumaraditya303
pushed a commit
to kumaraditya303/cpython
that referenced
this pull request
Oct 8, 2025
…e FS-based converters (pythonGH-139765) (cherry picked from commit b04a57d) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-139792 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
to kumaraditya303/cpython
that referenced
this pull request
Oct 8, 2025
…e FS-based converters (pythonGH-139765) (cherry picked from commit b04a57d) Co-authored-by: Bénédikt Tran <[email protected]>
kumaraditya303
added a commit
that referenced
this pull request
Oct 8, 2025
#139789) * [3.14] gh-139748: fix leaks in AC error paths when using unicode FS-based converters (GH-139765) (cherry picked from commit b04a57d) Co-authored-by: Bénédikt Tran <[email protected]>
kumaraditya303
added a commit
that referenced
this pull request
Oct 8, 2025
#139792) * [3.13] gh-139748: fix leaks in AC error paths when using unicode FS-based converters (GH-139765) (cherry picked from commit b04a57d) Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.