gh-139783: Fix inspect.getsourcelines() for the case when a decorator is followed by a comment or an empty line #139836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orator is followed by a comment or an empty line
serhiy-storchaka
added
needs backport to 3.13
vstinner
reviewed
Oct 9, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM
I'm just curious, what's the difference between tokenize.NL and tokenize.NEWLINE?
Member
|
See https://docs.python.org/3/library/token.html#token.NEWLINE:
and https://docs.python.org/3/library/token.html#token.NL:
|
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
serhiy-storchaka
deleted the
inspect-getsourcelines-comment-after-decorator
branch
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2025
…orator is followed by a comment or an empty line (pythonGH-139836) (cherry picked from commit f4104f5) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2025
…orator is followed by a comment or an empty line (pythonGH-139836) (cherry picked from commit f4104f5) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-139889 is a backport of this pull request to the 3.14 branch. |
|
GH-139890 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 10, 2025
…corator is followed by a comment or an empty line (GH-139836) (GH-139889) (cherry picked from commit f4104f5) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 10, 2025
…corator is followed by a comment or an empty line (GH-139836) (GH-139890) (cherry picked from commit f4104f5) Co-authored-by: Serhiy Storchaka <[email protected]>
Yhg1s
pushed a commit
to Yhg1s/cpython
that referenced
this pull request
Oct 14, 2025
…n a decorator is followed by a comment or an empty line (pythonGH-139836) (pythonGH-139890) (cherry picked from commit f4104f5) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspect.BlockFinderhandlestokenize.NEWLINEtoo strictly #139783