-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-139847: Add PyType_Lookup() function #139848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Sam Gross <[email protected]>
The CI fails with:
I added the |
|
I reverted changes to schedule |
|
@encukou: So what do you think of exposing this PyType function? |
|
I think there's benefit to exposing this but we need to do it carefully. The operation is different from getattr in surprising ways. The docs & tests should mention details -- not invoking descriptors or metaclass getattr. It might also be good for the docs to add an example of where Python uses this operaton, and/or equivalent Python code. “Lookup” is a new term in the public C API; are we sure this is the right operation for the name? |
Add Python pseudo-code in the doc.
Good idea. I added tests for that and completed the doc.
I added Python pseudo-code to the doc. |
📚 Documentation preview 📚: https://cpython-previews--139848.org.readthedocs.build/